Allow saving generated images to dir #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #22 +/- ##
==========================================
+ Coverage 87.50% 90.21% +2.71%
==========================================
Files 2 2
Lines 80 92 +12
==========================================
+ Hits 70 83 +13
+ Misses 10 9 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
This PR is not really a breaking change for adding missing images since this functionality didn't work on the previous releases. See #17 Edit: Although it is a breaking change for pyvista |
banesullivan
approved these changes
Dec 27, 2022
banesullivan
reviewed
Jan 6, 2023
Co-authored-by: Bane Sullivan <[email protected]>
…nerated_image_dir
MatthewFlamm
commented
Jan 6, 2023
|
Merging this after prior approval and merging with main with only minor changes afterwards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17 and closes #6. Allow saving generated images to dir.
TODO:
Reverse option for failing with extra image? IMO, it should be defaulted to fail here and an option to not fail.Will leave for a different PR